Removes warning about hidden being undefined #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * When compiling a view that used this module it would throw a warning saying that `hidden/0` was undefined This change addresses the need by: * Tricking the compiler to now throw the warning since we know that it will be defined as we're only calling it conditionally on the fact that it has been overridden.
zamith
force-pushed
the
remove-hidden-warnings
branch
from
ef65cb0
to
8c19660
Compare
|
@doomspork Rebased with master, which should fix the errors. Can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
saying that
hidden/0was undefinedThis change addresses the need by:
will be defined as we're only calling it conditionally on the fact that
it has been overridden.