Remove leading is_ from is_data_loaded? #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich prefer is_predicate for guard-safe macros and predicate? for regular boolean functions.
doomspork
approved these changes
Oct 2, 2018
|
Thank you @kbaird! @jeregrine any objections? I'm all for this. We'll need to bump the version of the new release you cut to account for the breaking change. |
|
You're welcome, @doomspork. I have a separate question about custom relationships in a View. Where's the best venue for that? EDIT: I just asked at #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style preferences are