Expand build matrix #151
Merged
Expand build matrix #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
force-pushed
the
feature/add-elixir-otp-versions
branch
2 times, most recently
from
a6b971a
to
7418ce4
Compare
doomspork
force-pushed
the
feature/add-elixir-otp-versions
branch
from
7418ce4
to
c813dc6
Compare
jherdman
reviewed
Dec 30, 2018
| - 19.3 | ||
| - 18.3 | ||
|
|
||
| matrix: | ||
| exclude: | ||
| - elixir: 1.6 | ||
| otp_release: 18.3 | ||
| - elixir: 1.5 | ||
| otp_release: 21.1 |
There was a problem hiding this comment.
I think you need to add an exclusion for 1.7 and OTP < 19 here too. See https://hexdocs.pm/elixir/compatibility-and-deprecations.html#compatibility-between-elixir-and-erlang-otp
There was a problem hiding this comment.
Are you sure? All the tests currently pass @jherdman
snewcomer
approved these changes
Dec 30, 2018
| - 19.3 | ||
| - 18.3 | ||
|
|
||
| matrix: | ||
| exclude: | ||
| - elixir: 1.6 | ||
| otp_release: 18.3 | ||
| - elixir: 1.5 | ||
| otp_release: 21.1 | ||
|
|
||
| env: | ||
| global: |
There was a problem hiding this comment.
I think sudo: false can be removed now. https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
There was a problem hiding this comment.
I'll remove sudo and push it up now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going the opposite way of #150 by actually expanding the matrix to include the latest Elixir and OTP releases. As mentioned on #150, we intentionally want multiple OTP releases so we can ensure the project compiles on different combinations of Elixir and OTP.