libassert_msvc_pfunc
is not defined when using Clang on Windows
#104
Labels
libassert_msvc_pfunc
is not defined when using Clang on Windows
#104
For compatibility reasons, the Windows version of Clang defines
_MSC_VER
, meaning libassert detects the compiler as MSVClibassert/include/libassert/platform.hpp
Lines 52 to 58 in b90077a
This causes some issues. For example,
ASSERT_VAL
eventually calls theLIBASSERT_INVOKE_VAL_PRETTY_FUNCTION_ARG
macro which in this scenario relies on a built-in that Clang doesn't support:libassert/include/libassert/assert.hpp
Lines 687 to 689 in b90077a
I think this can be fixed by just replacing the
#ifdef _MSC_VER
with#if defined(_MSC_VER) && !defined(__clang__)
. It fixes theASSERT_VAL
issue, but I'm not sure what else might change (though it should be fine since presumably it'll just switch to the clang version of libassert everywhere else as well).The text was updated successfully, but these errors were encountered: