Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closeOnOverlayTap not working with alwaysOpen prop #151 #152

Merged
merged 1 commit into from
Mar 20, 2020
Merged

closeOnOverlayTap not working with alwaysOpen prop #151 #152

merged 1 commit into from
Mar 20, 2020

Conversation

WesleyFaveri
Copy link
Contributor

No description provided.

@WesleyFaveri WesleyFaveri mentioned this pull request Mar 19, 2020
Closed
@jeremybarbet
Copy link
Owner

jeremybarbet commented Mar 20, 2020 •
edited
Loading

Looks good, I will merge and rename fullHeight to top to keep consistency with the onPositionChange callback function

Oops wrong PR, wrong tab, but this one looks good too ahah

@jeremybarbet jeremybarbet reopened this Mar 20, 2020
@jeremybarbet jeremybarbet merged commit 92db47b into jeremybarbet:master Mar 20, 2020
jeremybarbet added a commit that referenced this pull request Mar 20, 2020
@jeremybarbet
Revert "feat: added param to close overlay and condition to pointerEv…
60a5e70 
…ents #151 (#152)"

This reverts commit 92db47b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WesleyFaveri @jeremybarbet