Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alwaysOpen not working proper when we used adjustToContentHeight #172

Closed
ydv0121 opened this issue Apr 11, 2020 · 9 comments · May be fixed by #340
Closed

alwaysOpen not working proper when we used adjustToContentHeight #172

ydv0121 opened this issue Apr 11, 2020 · 9 comments · May be fixed by #340
Labels
🤕 Valid issue Something isn't working

Comments

@ydv0121
Copy link

ydv0121 commented Apr 11, 2020

Hello
First of all thank you for this awesome work.
I am facing one issue when i am using alwaysOpen and adjustToContentHeight together.
i passed alwaysOpen={100} and set adjustToContentHeight={true}.

so when after page load Modal render with default adjustToContentHeight size.
it should render with 100 which i passed in alwaysOpen

please tell me if i am missing something
@jeremybarbet
Copy link
Owner

Hi,

You are not missing anything, I just didn't test this case. It might be tricky to handle both cases together, I will try to look at it when I'm done with my list.

@jeremybarbet jeremybarbet added the 🤕 Valid issue Something isn't working label Apr 12, 2020
jeremybarbet added a commit that referenced this issue Apr 25, 2020
@jeremybarbet
fix: alwaysOpen and ajustToContentHeight #172
c37ecd5
@jeremybarbet
Copy link
Owner

Fixed and release in rc-25

@ydv0121
Copy link
Author

ydv0121 commented Apr 25, 2020

Fixed and release in rc-25

Damn you are flash🤘😅.
will try it.
Thank you man

@ydv0121
Copy link
Author

ydv0121 commented Apr 27, 2020

Hello @jeremybarbet
i am getting still same issue in rc-25
Modalize open default with adjustToContentHeight when using with alwaysOpen

My react-native version is 0.58.4

@jeremybarbet jeremybarbet reopened this Apr 27, 2020
@jeremybarbet
Copy link
Owner

jeremybarbet commented Apr 28, 2020 •
edited
Loading

https://b.ueno.is/WnuGlBAQ

Is that not what you were talking about? that adjustToContentHeight wasn't working while being used along with alwaysOpen props?

@ydv0121
Copy link
Author

ydv0121 commented Apr 30, 2020 •
edited
Loading

https://b.ueno.is/WnuGlBAQ

Is that not what you were talking about? that adjustToContentHeight wasn't working while being used along with alwaysOpen props?

its working now..issue with my node_modules or what i don't know but i reinstall the lib and its working now perfectly. Thank you man..Thanks

@ydv0121 ydv0121 closed this as completed Apr 30, 2020
@jeremybarbet
Copy link
Owner

Sweet, good to hear!

@ydv0121 ydv0121 mentioned this issue May 18, 2020
Closed
@eladgel
Copy link

eladgel commented Apr 27, 2021

@jeremybarbet There is an issue when you add HeaderComponent in this scenario where the action sheet doesn't open at all...

@ydv0121 ydv0121 mentioned this issue Jun 2, 2021
Open
This was referenced Jul 14, 2021
Closed
Open
@nirajniroula
Copy link

When HeaderComponent is passed, this issue is still there. You should either remove the HeaderComponent prop or the adjustToContentHeight prop to make the alwaysOpen prop work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤕 Valid issue Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@eladgel @jeremybarbet @nirajniroula @ydv0121