Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View methods overloading low performance #239

Open
Nice3point opened this issue May 16, 2024 · 3 comments
Open

View methods overloading low performance #239

Nice3point opened this issue May 16, 2024 · 3 comments
Labels
open discussion ☎️ An issue open for active community discussion

Comments

@Nice3point
Copy link
Collaborator

Execution of some methods takes quite a long time, about 4 seconds which is critical

Method Screen
CanCategoryBeHidden (ElementId) изображение
IsCategoryOverridable (ElementId) изображение

The reason for this is the presence of DWG links inside the families:

изображение

Should these methods be disabled or are they informative and should be kept?
In models without DWG they are executed 16 ms

@Nice3point Nice3point added the open discussion ☎️ An issue open for active community discussion label May 16, 2024
@ricaun
Copy link
Contributor

ricaun commented May 17, 2024

Maybe this methods that require category as input should be generated only if the user click in the method, if the project have a lot of categories RevitLookup is checking for each one even if the user does not need that information.

I wonder how many categories do you have in this 4 second sample.

@ricaun
Copy link
Contributor

ricaun commented Sep 6, 2024

I found a similar issue that is forcing everything to be resolved when the RevitLookup is opened.

Would be make sense to have some other kind of resolver that is only resolve when the user click, like Invoker.

public interface IDescriptorInvoker : IDescriptorCollector
{
    Func<IVariants> Invoke(Document context, string target, ParameterInfo[] parameters);
}

That would be handy Resolve/Invoke some custom methods only when the user need/want.

@Nice3point
Copy link
Collaborator Author

@ricaun it is planned to add such a feature, though there is no certainty about the implementation and architecture design yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open discussion ☎️ An issue open for active community discussion
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants