Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Metadata / Module(?) #45

Closed
jhollowayj opened this issue Sep 27, 2020 · 5 comments
Closed

Connection Metadata / Module(?) #45

jhollowayj opened this issue Sep 27, 2020 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@jhollowayj
Copy link

For some use cases, it would be nice to add metadata (name, weight, etc) to the connections between nodes/modules. Is this something that would be a) easy to implement and b) valuable to the general community?

I'd be happy to help implement it, but I'm new to this code base and would likely need a few pointers on where to get started, and how it would be best to architect this to work well with existing ideas and coding practices.

@jerosoler
Copy link
Owner

Hello @jhollowayj

You mean this right #18?

@jerosoler jerosoler self-assigned this Sep 28, 2020
@jerosoler jerosoler added the question Further information is requested label Sep 28, 2020
@jhollowayj
Copy link
Author

Yeah, I think so. I'd like to be able to have a text box in the middle of the line, or be able to change that text box to my own custom vue component. Does #18 completely cover that idea? If so, should we close this issue?

@jerosoler
Copy link
Owner

I close issue for duplicate.

I have the idea in mind that the inputs and outputs can be formed with a json or array when the node is added.

Currently it is like this:

editor.addNode ('github', 0, 1, 150, 300, 'github', data, html);

And I think it could be a solution to implement:

editor.addNode('github', 0, [
   { 
   label: 'For text label bullet or null for not display' , 
   labelconnection: 'Label of connection middle or null for not display',   
   type: 'For force only connection with input type or null for not display',   
    }, { ... }
 ] , 150, 300, 'github', data, html);

@techies-sudo
Copy link

techies-sudo commented Mar 24, 2021

Can you give a vue example for this?labeling on top of line.

@jerosoler
Copy link
Owner

Hello @techies-sudo

The labels on the lines have not been implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants