diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js index f3fa8fbb21..0b885bf134 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.new.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.new.js @@ -2869,7 +2869,6 @@ function commitMutationEffectsOnFiber( if (flags & Visibility) { const offscreenInstance: OffscreenInstance = finishedWork.stateNode; - const offscreenBoundary: Fiber = finishedWork; // Track the current state on the Offscreen instance so we can // read it during an event @@ -2880,11 +2879,16 @@ function commitMutationEffectsOnFiber( } if (isHidden) { - // Check if this is an update, and the tree was previously visible. - if (current !== null && !wasHidden) { - if ((offscreenBoundary.mode & ConcurrentMode) !== NoMode) { + const isUpdate = current !== null; + const isAncestorOffscreenHidden = offscreenSubtreeIsHidden; + // Only trigger disapper layout effects if: + // - This is an update, not first mount. + // - This Offscreen was not hidden before. + // - No ancestor Offscreen is hidden. + if (isUpdate && !wasHidden && !isAncestorOffscreenHidden) { + if ((finishedWork.mode & ConcurrentMode) !== NoMode) { // Disappear the layout effects of all the children - recursivelyTraverseDisappearLayoutEffects(offscreenBoundary); + recursivelyTraverseDisappearLayoutEffects(finishedWork); } } } else { @@ -2897,7 +2901,7 @@ function commitMutationEffectsOnFiber( if (supportsMutation && !isOffscreenManual(finishedWork)) { // TODO: This needs to run whenever there's an insertion or update // inside a hidden Offscreen tree. - hideOrUnhideAllChildren(offscreenBoundary, isHidden); + hideOrUnhideAllChildren(finishedWork, isHidden); } } diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js index ea1ff57f3d..cbbca98212 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.old.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.old.js @@ -2869,7 +2869,6 @@ function commitMutationEffectsOnFiber( if (flags & Visibility) { const offscreenInstance: OffscreenInstance = finishedWork.stateNode; - const offscreenBoundary: Fiber = finishedWork; // Track the current state on the Offscreen instance so we can // read it during an event @@ -2880,11 +2879,16 @@ function commitMutationEffectsOnFiber( } if (isHidden) { - // Check if this is an update, and the tree was previously visible. - if (current !== null && !wasHidden) { - if ((offscreenBoundary.mode & ConcurrentMode) !== NoMode) { + const isUpdate = current !== null; + const isAncestorOffscreenHidden = offscreenSubtreeIsHidden; + // Only trigger disapper layout effects if: + // - This is an update, not first mount. + // - This Offscreen was not hidden before. + // - No ancestor Offscreen is hidden. + if (isUpdate && !wasHidden && !isAncestorOffscreenHidden) { + if ((finishedWork.mode & ConcurrentMode) !== NoMode) { // Disappear the layout effects of all the children - recursivelyTraverseDisappearLayoutEffects(offscreenBoundary); + recursivelyTraverseDisappearLayoutEffects(finishedWork); } } } else { @@ -2897,7 +2901,7 @@ function commitMutationEffectsOnFiber( if (supportsMutation && !isOffscreenManual(finishedWork)) { // TODO: This needs to run whenever there's an insertion or update // inside a hidden Offscreen tree. - hideOrUnhideAllChildren(offscreenBoundary, isHidden); + hideOrUnhideAllChildren(finishedWork, isHidden); } } diff --git a/packages/react-reconciler/src/__tests__/ReactOffscreen-test.js b/packages/react-reconciler/src/__tests__/ReactOffscreen-test.js index f7ca087088..417f851ad4 100644 --- a/packages/react-reconciler/src/__tests__/ReactOffscreen-test.js +++ b/packages/react-reconciler/src/__tests__/ReactOffscreen-test.js @@ -281,13 +281,21 @@ describe('ReactOffscreen', () => { componentWillUnmount() { Scheduler.unstable_yieldValue('componentWillUnmount'); } + + componentDidMount() { + Scheduler.unstable_yieldValue('componentDidMount'); + } } + let _setIsVisible; + let isFirstRender = true; + function App() { const [isVisible, setIsVisible] = React.useState(true); - - if (isVisible === true) { + _setIsVisible = setIsVisible; + if (isFirstRender === true) { setIsVisible(false); + isFirstRender = false; } return ( @@ -303,7 +311,23 @@ describe('ReactOffscreen', () => { await act(async () => { root.render(); }); + + expect(Scheduler).toHaveYielded(['Child']); + expect(root).toMatchRenderedOutput(