Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to terser instead of uglifyjs #13

Open
pmiddend opened this issue Jun 14, 2024 · 2 comments
Open

Default to terser instead of uglifyjs #13

pmiddend opened this issue Jun 14, 2024 · 2 comments

Comments

@pmiddend
Copy link

I've just read that uglify-js is actually no longer maintained. However, terser is, and it's recommended by elm-optimize-level-2 as a replacement. Maybe mkElmDerivation should use terser, then? Usage seems exactly the same as uglifyjs.

@jeslie0
Copy link
Owner

jeslie0 commented Jun 15, 2024

The reason I used uglify-js was because that is was that is what Evan uses in the minification guide.

I have actually updated the way mkElmDerivation works by default to make it less opinionated. Essentially, all this does now is fetch the elm dependencies and puts them in the right place. It's then up to the user to run whatever elm commands they want to.

I am happy to update to terser if you think that is a good idea, but it will be updating legacy functionality of this repository. Would you benefit from that?

@pmiddend
Copy link
Author

Ahhh, I get what you're saying. It seems I'm still using an old version of mkElmDerivation that is more opinionated.

I will update mkElmDerivation then and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants