You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#> * checking CRAN incoming feasibility ... NOTE#> Version contains large components (1.0.2.9000)
And this:
Found the following (possibly) invalid URLs:
URL: https://osm.org/copyright (moved to https://www.openstreetmap.org/copyright)
From: README.md
Status: 200
Message: OK
I included my version while developing. This Github Action would run regularly once a week and after every commit/PR on branchs master or main,, checks are performed on devel, release, oldrel on Linux, macOS and Windows (as CRAN): https://github.com/dieghernan/tidygeocoder/actions/runs/620783144
Before removing it I just wanted to check if you would like to integrate this on your repo.
About batch geocoding
This is possible on Mapbox but under the commercial endpoint mapbox.places-permanent
I do not have that kind of access, so I didn't include it. I asked Mapbox Team if there is any way I can get a limited dev account for checking, I would let you know.
What I can do if this is strictly required is to include the capability using a mock answer of the API as example (see here), but I won't be able to check it if I don't get a permanent API key (maybe someone with that kind of key could help, @maxachis¿?).
Regards
The text was updated successfully, but these errors were encountered:
@dieghernan I tried to put a comment on one of your commits, but I can't find it now so maybe it didn't go through. I've pulled in your code and everything is working well. Good work on this. I added you as an author in the description file.
I also added an issue for whoever wants to add batch geocoding support for Mapbox (#73). We can just have someone who uses the permanent endpoint add it.
I haven't pulled the code into the master branch just yet so I haven't tried out the Github actions yet, but I think that's a good idea. I'll try it out. 👍
Following #62 , I have implemented Mapbox rebased on
reverse-geocoding
branch.Docs: https://docs.mapbox.com/api/search/geocoding/
Playground: https://docs.mapbox.com/playground/
See the checklist below:
Data
data-raw/api_reference.R
updatedR/data.R
Sandbox
sandbox/query_debugging/mapbox_test.R
sandbox/reverse_queries/mapbox_reverse.R
Code
R/utils.R
- Utils added for MapboxR/query_factory.R
updatedR/geo_methods.R
updatedR/geo.R
updatedR/reverse_geo.R
updatedTesting
testthat
test addedregression_testing.Rmd
Some Notes not related with the PR itself:
And this:
I checked and that url is generated by the response of the
reverse_geocode
on the README (see table on https://github.com/dieghernan/tidygeocoder/blob/master/README.md#usage), so not related with the package.Misc
There are two additional topics about which I would like to gather your feedback,
Integrate Github Action
Github Actions can run
R CMD CHECK
on a package repo over different platforms and R versions. I use this on my packages, you can see more on https://github.com/r-lib/actions/blob/master/examples/README.mdI included my version while developing. This Github Action would run regularly once a week and after every commit/PR on branchs
master
ormain
,, checks are performed on devel, release, oldrel on Linux, macOS and Windows (as CRAN):https://github.com/dieghernan/tidygeocoder/actions/runs/620783144
Before removing it I just wanted to check if you would like to integrate this on your repo.
About batch geocoding
This is possible on Mapbox but under the commercial endpoint
mapbox.places-permanent
https://docs.mapbox.com/api/search/geocoding/#batch-geocoding
I do not have that kind of access, so I didn't include it. I asked Mapbox Team if there is any way I can get a limited dev account for checking, I would let you know.
What I can do if this is strictly required is to include the capability using a mock answer of the API as example (see here), but I won't be able to check it if I don't get a permanent API key (maybe someone with that kind of key could help, @maxachis¿?).
Regards
The text was updated successfully, but these errors were encountered: