Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move patch into new commit with message #1963

Closed
mark2185 opened this issue May 23, 2022 · 6 comments
Closed

Move patch into new commit with message #1963

mark2185 opened this issue May 23, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@mark2185
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Usually when I use move patch into new commit I'd like to reword that commit, I'd rather get the popup with the Split from <patch message here"> as initial value than having to manually go back, reword the newly added commit, and return to the view where I was (since I want to split a few other things as well)

Describe the solution you'd like
Popup for the new commit message.

@mark2185 mark2185 added the enhancement New feature or request label May 23, 2022
@derteta
Copy link
Contributor

derteta commented Aug 27, 2022

I've had the same wish and made a prototype. It simply re-uses the "reword commit" prompt (meaning it also suffers from this issue). Would that work for you?

@mark2185
Copy link
Collaborator Author

Actually yes, that's exactly what I had in mind!

Except that I always get error: <changed file>: does not exist in index :)

Feel free to open a PR to continue the discussion there.

@derteta
Copy link
Contributor

derteta commented Aug 27, 2022

🤦 You're right! It was working at some point, must have messed up somewhere.
Will fix it, set up a PR and ping you in it!

Update: it works on some commits, but not on others. That's going to be a fun one.

@mark2185
Copy link
Collaborator Author

mark2185 commented Jan 2, 2023

@derteta are you able to open up a PR so we finish this up, doesn't seem like it needs too much additional work on top of what you've already done :)

@derteta
Copy link
Contributor

derteta commented Jan 5, 2023

Sure, can do.

@derteta derteta mentioned this issue Feb 11, 2023
6 tasks
@mark2185
Copy link
Collaborator Author

Solved by #2800 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants