Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some branch operations use checked out branch, others use selected branch #2795

Open
rukai opened this issue Jul 20, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@rukai
Copy link

rukai commented Jul 20, 2023

Describe the bug
In the "Local Branches" box, some branch operations use checked out branch, while others use the selected branch

To Reproduce
Steps to reproduce the behavior:

  1. check out a branch and then use j/k to select a different branch
  2. press P, this will push the checked out branch.
  3. press o, this will open a pull request for the selected branch

This is confusing since both commands operate on a single branch, so its not clear why there are two different mental models here.

Expected behavior

Either:

  • the menu brought up ? should display which operations use the checked out branch and which on the selected branch
  • all commands should operate on one or the other (obviously commands like rebase are excluded from this since they need to use both)

Screenshots
If applicable, add screenshots to help explain your problem.

Version info:

~> lazygit --version
commit=v0.38.2, build date=2023-05-03T15:21:01Z, build source=binaryRelease, version=0.38.2, os=linux, arch=amd64, git version=2.41.0
~> git --version
git version 2.41.0

This tool is really fantastic btw, thanks.

@rukai rukai added the bug Something isn't working label Jul 20, 2023
@stefanhaller
Copy link
Collaborator

Good points. Related to #2755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants