Confirmation view is sometimes not tall enough to fit content

[jesseduffield]

Describe the bug

Some messages aren't contained in their entirety inside the confirmation view.

This is a tricky one: we recently improved the word wrap behaviour in gocui, our underlying library: #2812.

But we have a function (

lazygit/pkg/gui/controllers/helpers/confirmation_helper.go

Line 64 in c390c9d

func getMessageHeight(wrap bool, message string, width int) int {

) in lazygit for determining the height of a confirmation message, and this function assumes the old behaviour of gocui. As such it thinks the message can fit within a tighter space than it actually can.

Some potential solutions:

• export the wrap logic from gocui so it can be used from lazygit
• add a field to gocui.View allowing it to extend its height to fit the content (up to a limit). This would require us centering the view properly back in the lazygit side
• something I haven't thought of yet

To Reproduce
In a small window, drop a commit, then press 'z' to undo and observe that the confirmation message
is not fully contained within the view.

Expected behavior
The confirmation view is taller to fit the message in its entirety

Screenshots

Version info:
commit=c390c9d58edc18083ed7f1a672b03b7c4d982c12, build date=2023-08-03T08:22:30Z, build source=unknown, version=c390c9d5, os=darwin, arch=amd64, git version=2.41.0