Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Nerd Fonts icon coverage on more remotes and file extensions #3426

Closed
hasecilu opened this issue Mar 24, 2024 · 0 comments · Fixed by #3484
Closed

Extend Nerd Fonts icon coverage on more remotes and file extensions #3426

hasecilu opened this issue Mar 24, 2024 · 0 comments · Fixed by #3484
Labels
enhancement New feature or request

Comments

@hasecilu
Copy link
Contributor

hasecilu commented Mar 24, 2024

As noted in the CONTRIBUTING file I open this issue before doing any change.

Is your feature request related to a problem? Please describe.

image

Describe the solution you'd like

  • Add various popular remotes to Lazygit, previous list would be nice =)
  • Associate more icons to popular file extensions.

Describe alternatives you've considered

  • The first option is to incorporate all these changes in the code
  • Another option is to create a config file that enables the user to add custom pairs of remotes url/file extensions and icons via config file.

Additional context

  • I have no Go experience but reading the code I can figure it out how to make the changes to add icons but not how to implement feature via config file.
  • Please, see the example of powerlevel10k for the remotes and the example of eza for the file extensions I'm interested on font-logos used in the wild lukas-w/font-logos#130

Extra comment

In the previous version the color for unstaged files covered status, icon and filename but now with recent update filenames seems to use default foreground color, the icons are colored even if they are not staged, leaving only the status with the "unstaged color". I think would be better to make all use the unstaged color as before and only change the icon color when the files is (partially) staged. Otherwise I think they distract a little.

image

I would love to have this changes on lazygit, do you think that are a good adition? If so to start on this unless you have some plans, would love to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant