DiffableDataSource: use weak self in _applyDiffSnapshot completion handler #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collection view may have disappeared from the view hierarchy before the `DiffableDataSource._applyDiffSnapshot` completion handler is called. Weakly retain self to ensure that `DiffableDataSource` does not outlive the collection view. Fixes jessesquires#125
jessesquires
requested changes
Aug 27, 2024
There was a problem hiding this comment.
Thanks so much @lachenmayer! 💯 🙌🏼 This is perfect.
Would you mind adding a changelog entry? We can add a new version, 0.1.6. (Just follow the existing format 😊)
|
Done :) |
|
Thanks @lachenmayer! 💯 |
|
@lachenmayer per the contributing guidelines, after having a PR get merged, you'll be added as a contributor. 😄 Invite sent. This gives you push access, so you no longer have to use a fork. No pressure to contribute further, but if you'd like to, you are very welcome to! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the Contributing Guidelines? 🖤
Closes #125
Describe your changes
As discussed in the issue, this fixes a crash with
Fatal error: Attempted to read an unowned reference but the object was already deallocatedwhen the collection view disappears from the view hierarchy while the animation is still in progress.Repro: https://github.com/lachenmayer/ReactiveCollectionsKitCrashRepro
Expected behavior: collection view appears & disappears a couple of times, and then the app crashes.
Repro with applied fix: https://github.com/lachenmayer/ReactiveCollectionsKitCrashRepro/tree/apply-fix
Expected behavior: collection view continuous to appear & disappear without a crash.