Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous data loading fails silently on network error #108

Open
cbiffle opened this issue Jul 13, 2015 · 0 comments
Open

Asynchronous data loading fails silently on network error #108

cbiffle opened this issue Jul 13, 2015 · 0 comments

Comments

@cbiffle
Copy link

cbiffle commented Jul 13, 2015

In the generated HTML webapp, network errors are not handled in any user-visible fashion.

Found in b3fc442

Steps to reproduce

Here's a local example that simulates a flaky internet connection / server.

  1. Generate docs.
  2. Run cldoc serve. It pops up yet another browser tab, but that's something for another issue report. :-)
  3. Kill cldoc serve (e.g. ^C).
  4. Click on a link in the browser tab.

Expected results

A browser "network problem" page. This is the right approach because, in modern browsers, it will kick off network connection status monitoring and may automatically retry the GET when the connection comes back, sometimes before the user notices.

Barring that, a custom dialog explaining that something has gone wrong.

Actual results

Nothing. You can click the link all you want.

If you happen to browse with your JavaScript Console open you might see something like the following:

Failed to load resource: net::ERR_CONNECTION_REFUSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant