Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Cannot find module 'typescript' after upgrade to 22.6.2 #269

Closed
tmorehouse opened this issue May 22, 2019 · 4 comments
Closed

Error Cannot find module 'typescript' after upgrade to 22.6.2 #269

tmorehouse opened this issue May 22, 2019 · 4 comments
Labels

Comments

@tmorehouse
Copy link

#!/bin/bash -eo pipefail
yarn lint
yarn run v1.13.0
$ eslint --ext .js,.md,.vue ./
Error: Cannot find module 'typescript'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:609:15)
    at Function.Module._load (internal/modules/cjs/loader.js:535:25)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/root/project/bootstrap-vue/node_modules/@typescript-eslint/typescript-estree/dist/parser.js:17:25)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Exited with code 1

Looks like typescript also needs to be moved to dependencies

@shazron
Copy link

shazron commented May 22, 2019

I got the warning that I need typescript as a peer dep:
npm WARN @typescript-eslint/experimental-utils@1.9.1-alpha.10 requires a peer of typescript@* but none is installed. You must install peer dependencies yourself.

...so I installed it in my devDeps, but now I get this error: #268

@SimenB SimenB closed this as completed in 1ce1402 May 22, 2019
@wmertens
Copy link

I guess it needs to be a peerDep because the version of typescript may differ per repo, but at least it should ignore missing typescript for repos that don't use typescript

@SimenB
Copy link
Member

SimenB commented May 22, 2019

Should be a new release whenever https://www.githubstatus.com/incidents/nf4gcjtcsqdb is gone

@SimenB
Copy link
Member

SimenB commented May 22, 2019

🎉 This issue has been resolved in version 22.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

adeira-github-bot pushed a commit to kiwicom/eslint-config-kiwicom that referenced this issue May 22, 2019
….6.3)

There was a small hiccup with Typescript dependencies but should be fixed now. See: jest-community/eslint-plugin-jest#269

kiwicom-source-id: 196c2156fa118cb1a6defe708cec484c6fb42d96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants