fix!: remove no-alias-methods from style config
#1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
force-pushed
the
no-alias-methods
branch
from
1a53426 to
707b2f1
Compare
|
While technically a fix, changing configs is usually considered a breaking change for eslint plugins and we're expecting to do a new major "soon" so I don't think we can land this for now |
Even removing rules from configs? It will technically result in less lint errors, so that shouldn't be breaking. But well, most people probably extend I'll change the commit message to include a |
FloEdelmann
force-pushed
the
no-alias-methods
branch
from
707b2f1 to
16c82c3
Compare
FloEdelmann
changed the title
no-alias-methods from style configno-alias-methods from style config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1678.