From e876ae0dd996b51318bc59a859a0c3af3d668e03 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Mon, 8 Mar 2021 14:29:20 +0100 Subject: [PATCH] Revert "fix(jest-runner): handle test failures with circular objects (#10981) (#11172) --- CHANGELOG.md | 1 - e2e/__tests__/circularInequality.test.ts | 2 +- packages/jest-runner/src/index.ts | 7 +------ 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32643cd73b8c..30131f5f1639 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,7 +50,6 @@ - `[jest-reporter]` Handle empty files when reporting code coverage with V8 ([#10819](https://github.com/facebook/jest/pull/10819)) - `[jest-resolve]` Replace read-pkg-up with escalade package ([#10781](https://github.com/facebook/jest/pull/10781)) - `[jest-resolve]` Disable `jest-pnp-resolver` for Yarn 2 ([#10847](https://github.com/facebook/jest/pull/10847)) -- `[jest-runner]` Handle test failures with circular objects ([#10981](https://github.com/facebook/jest/pull/10981)) - `[jest-runtime]` [**BREAKING**] Do not inject `global` variable into module wrapper ([#10644](https://github.com/facebook/jest/pull/10644)) - `[jest-runtime]` [**BREAKING**] remove long-deprecated `jest.addMatchers`, `jest.resetModuleRegistry`, and `jest.runTimersToTime` ([#9853](https://github.com/facebook/jest/pull/9853)) - `[jest-runtime]` Fix stack overflow and promise deadlock when importing mutual dependant ES module ([#10892](https://github.com/facebook/jest/pull/10892)) diff --git a/e2e/__tests__/circularInequality.test.ts b/e2e/__tests__/circularInequality.test.ts index 49a87762e950..a74ef44df19c 100644 --- a/e2e/__tests__/circularInequality.test.ts +++ b/e2e/__tests__/circularInequality.test.ts @@ -26,7 +26,7 @@ afterEach(() => { cleanup(tempDir); }); -test('handles circular inequality properly', async () => { +test.skip('handles circular inequality properly', async () => { const testFileContent = ` it('test', () => { const foo = {}; diff --git a/packages/jest-runner/src/index.ts b/packages/jest-runner/src/index.ts index 19c1bd14d18a..b58d881416f4 100644 --- a/packages/jest-runner/src/index.ts +++ b/packages/jest-runner/src/index.ts @@ -166,12 +166,7 @@ export default class TestRunner { const worker = new Worker(TEST_WORKER_PATH, { exposedMethods: ['worker'], - forkOptions: { - // use advanced serialization in order to transfer objects with circular references - // @ts-expect-error: option does not exist on the node 10 types - serialization: 'advanced', - stdio: 'pipe', - }, + forkOptions: {stdio: 'pipe'}, maxRetries: 3, numWorkers: this._globalConfig.maxWorkers, setupArgs: [