Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: .eslintcache files were shipped to NPM with v29.4.0 #13818

Closed
mrazauskas opened this issue Jan 25, 2023 · 3 comments · Fixed by #13832
Closed

[Bug]: .eslintcache files were shipped to NPM with v29.4.0 #13818

mrazauskas opened this issue Jan 25, 2023 · 3 comments · Fixed by #13832

Comments

@mrazauskas
Copy link
Contributor

Version

29.4.0

Steps to reproduce

See: https://www.npmjs.com/package/jest-runner/v/29.4.0?activeTab=explore

Screenshot 2023-01-25 at 21 41 55

Expected behavior

.eslintcache should not be shipped to NPM.

Actual behavior

For some reason .eslintcache was shipped with v29.4.0 packages. I checked few of the packages, the file was included in each of them. Older versions of the same packages do not include .eslintcache.

Would be easy to add it to .npmignore, but why did that happen only with this release?

Additional context

No response

Environment

N/A
@SimenB
Copy link
Member

SimenB commented Jan 26, 2023

Weird. Running npm pack in each module excludes it (I would assume all dotfiles were skipped by default). Not sure why running Lerna would result in something different.

image

@SimenB
Copy link
Member

SimenB commented Jan 26, 2023

Actually, I see that yarn pack includes it. Maybe lerna shells out to the package manager in the project?

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants