Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Github reporter shows skipped tests as failures #14278

Closed
richvdh opened this issue Jun 27, 2023 · 4 comments · Fixed by #14309
Closed

[Bug]: Github reporter shows skipped tests as failures #14278

richvdh opened this issue Jun 27, 2023 · 4 comments · Fixed by #14309

Comments

@richvdh
Copy link

richvdh commented Jun 27, 2023

Version

29.5.0

Steps to reproduce

  1. Clone repo at https://github.com/richvdh/jest-test
  2. npm install
  3. GITHUB_ACTIONS=1 npm test

Expected behavior

Skipped test should not be shown as a failure. Rather it should be shown as SKIP, with a symbol instead of a cross (like the default reporter).

Actual behavior

Skipped test is shown as a failure:

  FAIL test.js (88 ms)
    × no-op (1 ms)

Additional context

No response

Environment

System:
    OS: Linux 6.1 Ubuntu 22.04.2 LTS 22.04.2 LTS (Jammy Jellyfish)
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-1260P
  Binaries:
    Node: 20.2.0 - ~/.nvm/versions/node/v20.2.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v20.2.0/bin/yarn
    npm: 9.6.6 - ~/.nvm/versions/node/v20.2.0/bin/npm
  npmPackages:
    jest: ^29.5.0 => 29.5.0
@mrazauskas
Copy link
Contributor

@MatteoH2O1999 could you take a look, please?

@MatteoH2O1999
Copy link
Contributor

Yeah that's my bad. I initially only coded for passed and failed and never got around to add the other symbols. I'll try to fix this during the weekend

@SimenB
Copy link
Member

SimenB commented Jul 27, 2023

https://github.com/jestjs/jest/releases/tag/v29.6.2

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants