Coverage flag breaks snapshot test

[ColCh]

I think it's because of code instrumentation

jest --coverage

    - Snapshot
    + Received
...
    -   onSelect={[Function onSelectHandler]}
    +   onSelect={[Function anonymous]}

Running with jest is just OK.

Source code and func name for onSelectHandler:
jest:

    console.log src/components/pie-chart.js:44
      [Function: onSelectHandler]
    console.log src/components/pie-chart.js:45
      function onSelectHandler(_ref2){var nativeEvent=_ref2.nativeEvent;

      if(!onSelect){
      return;
      }
      onSelect(nativeEvent.index);
      }

And for jest --coverage:

    console.log src/components/pie-chart.js:44
      [Function]
    console.log src/components/pie-chart.js:45
      function (_ref2){var nativeEvent=_ref2.nativeEvent;++__cov_742n7agVtRgakP6RGrGnDGRBizg.f['3'];++__cov_742n7agVtRgakP6RGrGnDGRBizg.s['7'];

      if(!onSelect){++__cov_742n7agVtRgakP6RGrGnDGRBizg.b['1'][0];++__cov_742n7agVtRgakP6RGrGnDGRBizg.s['8'];
      return;
      }else{++__cov_742n7agVtRgakP6RGrGnDGRBizg.b['1'][1];}++__cov_742n7agVtRgakP6RGrGnDGRBizg.s['9'];
      onSelect(nativeEvent.index);
      }

How I can avoid this issue? Force use anonymous functions on every place? 😯

[nornagon]

I've also noticed tests that pass consistently without --coverage break consistently when --coverage is passed. I'm not sure how to inspect the instrumented code, but happy to help out debugging this if I can.

[ColCh]

Degugging:

console.log(onSelectHandler);
console.log(onSelectHandler+'');

First line will show function name, second will show function source code.

I think this issue comes from istanbul, I can investigate it tomorrow

[cpojer]

cc @DmitriiAbramov

[ColCh]

Yes, this is istanbul.

Related issue: gotwarlost/istanbul#699

For now, I wanted to point out a hotfix for that. Just wrap your named func into anonymous proxy func:

@@ -44,7 +44,7 @@ const PieChart = ({
   return (
     <RCTPieChart
       chartRotation={chartRotationInRadians}
-      onSelect={onSelectHandler}
+      onSelect={(...args) => onSelectHandler(...args)}
       segments={processedSegments}

And snapshot transforms then to this:

@@ -2,7 +2,7 @@ exports[`PieChart Android should render pie chart 1`] = `
 <RCTPieChart
   chartRotation={-0.2617993877991494}
   innerCircleRadius={0.55}
-  onSelect={[Function onSelectHandler]}
+  onSelect={[Function onSelect]}
   segments={
     Array [
       Object {

However, this is a hack...

[aaronabramov]

yeah.. it seems like there's nothing we can do on the jest side, unless we omit function names in snapshots.
in theory it should be possible for istanbul to keep the names of most of the functions using only static analysis, right?

[ColCh]

@DmitriiAbramov Take a look on my snippets above...

Recap. Given this handler (AFAIK it should be an anonymous function):

 onSelect={(...args) => onSelectHandler(...args)}

It writes this handler in snapshot:

onSelect={[Function onSelect]}

How can it be?

[cpojer]

Yeah we should probably just get rid of function names in the snapshots. I originally liked this a lot but it is causing more trouble than it is worth.

[cpojer]

Will be fixed in 16.

[guigrpa]

Hmmm... doesn't solve the problem completely if for some reason you're snapshotting a React element. It's name will turn Unknown in the snapshot when you enable --coverage.

[vincentaudebert]

+1 @guigrpa

That's what I get after running jest --watch just after running jest --coverage (and having updated my snapshots with coverage)

[dotfold]

In my case I'm using enzyme to snapshot a functional stateless component in React, and I get a failed snapshot assertion with coverage enabled, but it's not Unknown - for me it renders Component:

-     <ListItem
+     <Component
          active={false}
          item={
            Object {
              "id": "thing",
              "name": "stuff",
            }
          }
          onClick={[Function]} />

I'd be happy to isolate a repro case for this setup if it helps at all. The curious part here is that all my other snapshots are fine, it's just this instance of snapshotting a functional stateless component that has this differing output.

[thymikee]

@dotfold if you can isolate the test case, please file a new issue with it.

[vincentaudebert]

If it helps, I get the Unknown on stateless components too. Could give a hint on where to look for.

[vincentaudebert]

@thymikee I'm working on this at the moment https://github.com/springload/mocha-chai-to-jest

If you checkout the repo, set it up and run npm run test:jest:coverage you will get the error with the stateless component StatelessAnimal used inside CatBar component.

I quickly tried to use a statefull component like HatchingAnimal inside CatBar and I can confirm it doesn't trigger the error. The HatchingAnimal component is generated properly.

Let me know if this helps.

[thymikee]

For stateless components you need to define displayName prop of the Component. See this thread for more background: #1824 (comment)

[vincentaudebert]

@thymikee Cool it fixed my problem. I'm just wondering how come the "normal" jest testing finds the name properly and why the coverage doesn't?

Also using displayName property could lead to some typo mistakes, etc. Why not just use the component name? Like what "normal" jest seems to do.

[thymikee]

yeah this kind of sucks. Istanbul wraps functions with other anonymous functions and we take the function name that node gives to the rendered component :(
~ @cpojer

[cpojer]

Node 6 infers function names.

Example:

const Banana = () => {};
console.log(Banana.name); // "Banana"

this wasn't possible in previous versions of node.

It works fine when you aren't using coverage but when you do, here is what istanbul does to your code:

const Banana = (__cov[…], () => {});
console.log(Banana.name) // empty

because of how the expression is defined, node cannot infer the name properly. The only way to fix it is in istanbul itself or by using a babel transform that changes const Banana = () => {} to const Banana = function Banana() {}.

[tomchentw]

const Banana = (__cov[…], () => {});
console.log(Banana.name) // empty
@cpojer: because of how the expression is defined, node cannot infer the name properly.

Exactly!

I've recently encountered this issue and I tried to fix it on the istanbul side. I forked babel-plugin-istanbul to fix this, and I put my discovery in here:

istanbuljs/babel-plugin-istanbul#125

Could you folks let me know what you think about my proposal?

[CGamesPlay]

Per istanbuljs/babel-plugin-istanbul#125 (comment) this is now fixed in babel-plugin-istanbul@4.1.5 but requires jest --no-cache in order to work. @cpojer, can this issue be re-opened? Could file a separate one if need by.

[tomchentw]

@CGamesPlay you can use jest@^21.3.0-beta.2 and run yarn jest --clearCache. After this, jest should compile your code with the new istanbul instrument code for no problem (no --no-cache is needed).

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.