AssertionError: false == true

[piuccio]

Do you want to request a feature or report a bug?

Bug (?)

What is the current behavior?

Quoting from isaacs/rimraf#155 and GoogleChrome/lighthouse#2618

When I run chrome-headless I get the error

assert.js:81
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at rmdir (/Users/fabio/repo/prerender-chrome-headless/node_modules/chrome-launcher/node_modules/rimraf/rimraf.js:159:5)
    at /Users/fabio/repo/prerender-chrome-headless/node_modules/chrome-launcher/node_modules/rimraf/rimraf.js:95:13
    at FSReqWrap.oncomplete (fs.js:114:15)
The offending line is this [one](https://github.com/isaacs/rimraf/blob/master/rimraf.js#L217) and the assertion fails because originalEr appears not to be an instance of Error.

...

You can reproduce it by cloning this repo and running npm test.
I'm on Mac OSX 10.12.4
Node 7.10.0
It happens on node 6.11.0 and 8.1.2 as well.
For some reason, when lighthouse calls rimraf, it causes standard fs errors to not be instanceof Error. This is causing rimraf's assertions to fail.

What is the expected behavior?

No error

[paulirish]

Looks like whatever the issue was, it was fixed between rimraf@2.2.8 and rimraf@2.3.0.

This can be closed. :)

[thymikee]

@paulirish thank you!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.