Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: don't wrap multiline strings in quotes in pretty-format #4179

Closed
thymikee opened this issue Aug 2, 2017 · 1 comment
Closed

Proposal: don't wrap multiline strings in quotes in pretty-format #4179

thymikee opened this issue Aug 2, 2017 · 1 comment

Comments

@thymikee
Copy link
Collaborator

thymikee commented Aug 2, 2017

Do you want to request a feature or report a bug?
Breaking change

What is the current behavior?
Multiline strings are wrapped in double quotes (") like this:

screen shot 2017-08-02 at 17 03 10

Also inner quotes are escaped, which clutters e.g. the snapshot of such string.

What is the proposed behavior?
Since we're inside a template literal, I think it would be nice to treat multiline strings specially and get rid of this clutter:

screen shot 2017-08-02 at 17 03 28

This would be especially helpful for snapshot helpers like snapshot-diff.

cc @cpojer @aaronabramov @pedrottimark @ferrannp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants