Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About badge in the document #5438

Closed
aleen42 opened this issue Feb 2, 2018 · 9 comments
Closed

About badge in the document #5438

aleen42 opened this issue Feb 2, 2018 · 9 comments
Labels
Discussion

Comments

@aleen42
Copy link
Contributor

aleen42 commented Feb 2, 2018 •
edited
Loading

I have created a new badge for Jest with the project badges, and I hope it can be accepted to be an official one. Thanks.

jest
@thymikee
Copy link
Collaborator

thymikee commented Feb 2, 2018

Nice! I wonder if lighter (e.g. white) background under the logo wouldn't be better?

@thymikee
Copy link
Collaborator

thymikee commented Feb 2, 2018

cc @cpojer @ericnakagawa

@aleen42
Copy link
Contributor Author

aleen42 commented Feb 2, 2018

The badge is generated with the official designed logo with SVG formatted, and if you want a lighter white border, I have to say I do need abother source file.

@thymikee
Copy link
Collaborator

thymikee commented Feb 2, 2018

Sorry for the confusion, I mean the background, not the logo color 😅
screen shot 2018-02-02 at 11 23 32
screen shot 2018-02-02 at 11 23 59

@cpojer
Copy link
Member

cpojer commented Feb 2, 2018

This is cool!

@aleen42
Copy link
Contributor Author

aleen42 commented Feb 2, 2018

@thymikee greate idea, and I will make it true soon.

@aleen42
Copy link
Contributor Author

aleen42 commented Feb 3, 2018 •
edited
Loading

  • jest
  • jest

Also check the list: https://github.com/aleen42/badges/

@thymikee
Copy link
Collaborator

thymikee commented Feb 4, 2018

Looks cool! The second one fits nicer in GitHub's light theme imho. Feel free to send a PR adding these to README and maybe under "Join the community" section in https://facebook.github.io/jest/en/help.html? :)

@aleen42
Copy link
Contributor Author

aleen42 commented Feb 5, 2018

👌

aleen42 added a commit to aleen42/jest that referenced this issue Feb 5, 2018
@aleen42
Docs: Adding Suggested Badge (jestjs#5438)
642bcef
@aleen42 aleen42 mentioned this issue Feb 5, 2018
Merged
@aleen42 aleen42 changed the title Aboud badge in the document About badge in the document Feb 5, 2018
aleen42 added a commit to aleen42/jest that referenced this issue Feb 5, 2018
@aleen42
Docs: Adding Suggested Badge (jestjs#5438)
e66ec2b
aleen42 added a commit to aleen42/jest that referenced this issue Feb 5, 2018
@aleen42
Docs: Adding Suggested Badge (jestjs#5438)
c87067c
cpojer pushed a commit that referenced this issue Feb 5, 2018
@aleen42 @cpojer
Docs: Adding Suggested Badge (#5438) (#5458)
bda02e6
@thymikee thymikee closed this as completed Feb 5, 2018
@renovate renovate bot mentioned this issue Feb 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpojer @thymikee @aleen42