expect(Infinity).toBeCloseTo(Infinity) fails

[nampord]

For consistency it would be good if .toBeCloseTo could handle Infinity gracefully :

any number should not be close to Infinity at any precision
Infinity should be close to Infinity at any precision

any number should not be close to -Infinity at any precision
-Infinity should be close to -Infinity at any precision

-Infinity should not be close to Infinity at any precision

[thymikee]

Mind sending a PR with this enhancement? :)

[michaeldera]

This could be something I'd like to do

[pbondoer]

@michaeldera Are you working on this? I'd like to do this as my first PR ✨

[michaeldera]

No I am not, you can go ahead and have a go at it @pbondoer

[rickhanlonii]

@pbondoer happy to hear! Check out the contributing guide here and lmk if you have any questions 👍

[Sharcoux]

Is really infinity close to infinity??
Mathematically speaking this is stupid. n^2 and n tends to be less and less close to each other when n tends to infinity... Some infinities are much bigger than others.

[michaeldera]

I think that was the point of the issue @Sharcoux

[rickhanlonii]

Good point @Sharcoux, but I think as at a programming API level, people expect .toBeCloseTo to include anything that is isEqual and the global Infinity is equal to itself irrespective of the character of infinity it's representing

[joao-conde]

I have a solution for this issue ready to go, but I've noticed I did not announce my intent to solve this issue, so @pbondoer is probably on it. Even so, since I solved it, may I PR?

[rickhanlonii]

@joao-conde I'd say go ahead and submit it

[SimenB]

Fixed by #7444

[pbondoer]

Hey @joao-conde, thanks for submitting the PR. I had some personal stuff to take care of and couldn't get to it. Good thing you did! 👍

[joao-conde]

No problem, hope everything's sorted out for you!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.