Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-circus changes behaviour of it.only inside describe.only #7837

Closed
theneva opened this issue Feb 8, 2019 · 4 comments · Fixed by #7888
Closed

jest-circus changes behaviour of it.only inside describe.only #7837

theneva opened this issue Feb 8, 2019 · 4 comments · Fixed by #7888

Comments

@theneva
Copy link
Contributor

theneva commented Feb 8, 2019

🐛 Bug Report

jest-circus runs all its inside a describe.only block regardless of it.only:

image

This differs from jest-jasmine2, which only runs the it marked with it.only.

image

To Reproduce

Run a test suite containing a describe.only block with at least one it.only and one it. Please see the above screenshots.

Expected behavior

I would expect jest-circus and jest-jasmine2 to run the same set of tests, unless this is an intentional difference 😄

Link to repl or repo (highly encouraged)

The repo used to grab the screenshots is available at https://github.com/theneva/jest-only.

Run npx envinfo --preset jest

Paste the results here:

$ npx envinfo --preset jest

npx: installed 1 in 1.511s

  System:
    OS: macOS 10.14.2
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 10.13.0 - ~/.nvm/versions/node/v10.13.0/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.13.0/bin/npm
  npmPackages:
    jest: ^24.1.0 => 24.1.0
@doniyor2109
Copy link
Contributor

Hi. Can I work on this issue?

@jeysal
Copy link
Contributor

jeysal commented Feb 13, 2019

Go for it! And don't hesitate to ask if you need any help :)

@elicast82
Copy link

#7837 (comment)

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants