unable to custom define babel plugins for istanbul-lib-instrument?

[JounQin]

🚀 Feature Proposal

Support custom babel plugins for istanbul-lib-instrument.

Motivation

istanbuljs/istanbuljs#465 (comment)

Example

Please see above PR.

[SimenB]

Please provide more details, such as a (minimal) repository showing what you want to do and how Jest falls short. We only use istanbul-lib-instrument directly here: https://github.com/facebook/jest/blob/736edd2ea6c9aadfb6e8794ecdc8a726f8a76b1a/packages/jest-reporters/src/generateEmptyCoverage.ts#L9

The code goes through the transformer though, so all of your babel config should be picked up. So I don't understand what you're asking for.

[JounQin]

@coreyfarrell @JaKXz It's not about transform, it's about coverage collection. My test cases passed, but the coverage collection failed because istanbul-lib-instrument can't recognize the valid syntax.

You can check https://github.com/rx-ts/babel-preset-proposal-typescript, remove the postinstall script first which does a trick for patching istanbul-lib-instrument inside node_modules, and simply run yarn && yarn test. It will throw an error, and I don't know how to prevent it in jest configuration.

istanbuljs/istanbuljs#465 (comment)

@SimenB Please check. Or it would be better to look through the context from original issue.

[SimenB]

That's a PR without an opening post and the repo you link to is far from minimal.

https://www.snoyman.com/blog/2017/10/effective-ways-help-from-maintainers

[JounQin]

The PR comments should be very clear that I'm trying to test babel plugin v8intrinsic which is first available from v7.6.0, but for now it's not possible to add this additional babel plugin into istanbul-lib-instrument because we don't provide any config option to do this, and it breaks jest coverage collection (The test cases themselves passed).

Whatever, I'll trigger a CI build with error to reproduce it for you.

[JounQin]

Can you check https://travis-ci.com/rx-ts/babel-preset-proposal-typescript/builds/126952573#L283?

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.