-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshots are different on linux and windows when contain \\
#9614
Comments
@pedrottimark ideas? |
The regexp part of So I'm not sure where to begin looking into this... Maybe the equality function just lies? It was tweaked in #9167. return (
a.source == b.source &&
a.global == b.global &&
a.multiline == b.multiline &&
a.ignoreCase == b.ignoreCase
); to return a.source === b.source && a.flags === b.flags; I wouldn't expect that to result in this change, though... |
@SimenB I can spent my time on searching a problem, I'm afraid that it will take me more time for me, so I created the problem, suddenly there are some known potential problem areas |
Hmm I'd be surprised if it was related to that too. It should only matter for flags other than those 3 |
This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stalled for 7 days with no activity. Please open a new issue if the issue is still relevant, linking to this one. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
🐛 Bug Report
Snapshoting RegExp on windows and linux are difference when it is contains
\\
.To Reproduce
Expected behavior
Snapshots should escaped property and equally on windows and linux
Link to repl or repo (highly encouraged)
Original issue: webpack/webpack#10443
envinfo
Additional information: there were no problems using
jest@24
, looks like it is a regressionThe text was updated successfully, but these errors were encountered: