projects and collectCoverageFrom do not work together

[royra]

🐛 Bug Report

We're using using Jest's projects feature to run tests in all packages of a monorepo concurrently. It's blazingly fast, and especially useful in CI ❤️ .

The problem is that some packages need to exclude a pattern (e.g, /index.js) from test coverage. Other packages need to include the same pattern in their test coverage.

Specifying collectCoverageFrom in each package's config works when running Jest at the specific package. When running at the repo root (using projects), the individual collectCoverageFrom props are ignored.

Specifying collectCoverageFrom at the root config does not work: The package path is not included in the tested path/glob, and so you cannot include package1/index.js while excluding package2/index.js.

To Reproduce

• Have two packages with the same relative source filename, (e.g, index.js at the package root).

• Try to include only one package's file in coverage, while excluding the other package's file.

Expected behavior

To keep things DRY, I would prefer if collectCoverageFrom at the root config would be inherited from the individual project's config.

Another option is specifying the project's path in collectCoverageFrom at the root:

{
  "collectCoverageFrom": [
    "packages/package1/index.js",
    "!packages/package2/index.js"
  ]
}

Link to repo

https://github.com/salto-io/jest_projects_coverage_issue

envinfo

 System:
    OS: macOS 10.15.3
  Binaries:
    Node: 12.14.1 - ~/.nvm/versions/node/v12.14.1/bin/node
    Yarn: 1.22.0 - ~/.nvm/versions/node/v12.14.1/bin/yarn
    npm: 6.13.4 - ~/.nvm/versions/node/v12.14.1/bin/npm

Jest version: 25.1.0
(Also tried with 24.9)

[royra]

Added PR #9633 which implements the DRY solution described above.

[shahinghasemi]

The problem still exists, any solution?

[JCMais]

The solution in my case was to add the collectCoverageFrom to the root config (not inside projects)

[piranna]

I'm facing the same problem too.

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[Yegorich555]

Ping

[thunder033]

We're hacking around this by dynamically including coverageThreshold values in our jest.config.ts:

const selectIndex = process.argv.indexOf('--selectProjects');
const endIndex = process.argv.findIndex((arg, i) => arg.startsWith('--') && i > selectIndex);
const projects = process.argv.slice(selectIndex + 1, endIndex > -1 ? endIndex : undefined);

const coverageThresholds: Record<string, CoverageThresholdValue> = {
  'apps/my-app': {
    lines: 25,
    statements: 25,
    branches: 17,
    functions: 20,
  },
};

const isSelectedProject = (path: string) =>
  projects.some((project) => path.split('/').includes(project));

export default {
   ...
   coverageThresholds: {
      global: {
        lines: 80,
        statements: 80,
        branches: 70,
        functions: 80,
      },
      ...Object.entries(coverageThresholds).reduce(
        (out, [path, value]) => ({ ...out, ...(isSelectedProject(path) ? { [path]: value } : {}) }),
        {},
      ),
   }
   ...
}

[github-actions]

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

[piranna]

No stale.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.