Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-watcher: ShouldRunTestSuite type should allow to return boolean #9725

Closed
ahnpnl opened this issue Mar 29, 2020 · 1 comment · Fixed by #9753
Closed

jest-watcher: ShouldRunTestSuite type should allow to return boolean #9725

ahnpnl opened this issue Mar 29, 2020 · 1 comment · Fixed by #9753

Comments

@ahnpnl
Copy link
Contributor

ahnpnl commented Mar 29, 2020

🐛 Bug Report

Missing return boolean for type ShouldRunTestSuite

To Reproduce

In the documentation of watch-plugins for jestHooks.shouldRunTestSuite(testSuiteInfo) mentioning that it is possible to return a boolean. However, when inspecting jest-watcher/build/types.d.ts and observe this

export declare type ShouldRunTestSuite = (testSuiteInfo: TestSuiteInfo) => Promise<boolean>;

Expected behavior

The type should be

export declare type ShouldRunTestSuite = (testSuiteInfo: TestSuiteInfo) => Promise<boolean> | boolean;

Link to repl or repo (highly encouraged)

N.A.

envinfo

System:
    OS: macOS 10.15.3
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 12.16.1 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
  npmPackages:
    jest: ^25.2.4 => 25.2.4 
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant