fix(*): Lower Node requirement to 16.10 #12754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Apr 27, 2022
SimenB
changed the title
F3n67u
pushed a commit
to F3n67u/jest
that referenced
this pull request
May 2, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Node JS 16.11 brings in a change that has significant memory and performance issues with Jest - #11956. It has been identified as a upstream bug, but it has not been fixed. Since people who use yarn get the engine enforced (or decide to opt out for all packages) this pushes people upgrading to Jest 28 on to the buggy node version, which for large projects makes jest unworkable and small projects slower. So, as agreed on the bug I am lowering the required node v16 minor version to allow this work-around to continue to work.