Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: handle both ms and s in test timings #5132

Merged
merged 2 commits into from
Dec 19, 2017
Merged

test: handle both ms and s in test timings #5132

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d246b63
test: handle both `ms` and `s` in test timings
SimenB Dec 19, 2017
7a6ef51
test: add `$` to only match end of string
SimenB Dec 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_tests/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const extractSummary = (stdout: string) => {

const rest = cleanupStackTrace(
// remove all timestamps
stdout.slice(0, -match[0].length).replace(/\s*\(.*ms\)/gm, ''),
stdout.slice(0, -match[0].length).replace(/\s*\(\d*\.?\d+m?s\)/gm, ''),
Copy link
Member Author

@SimenB SimenB Dec 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding m?s made a single other test fail, so this is copied from the cleanup regexp above

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth to add a $ so we match only the end of the string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that probably would have fixed it. added it anyways 🙂

);

return {rest, summary};
Expand Down