Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Configuration.md #5287

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Update Configuration.md #5287

merged 2 commits into from
Jan 12, 2018

Conversation

rafalp
Copy link
Contributor

@rafalp rafalp commented Jan 11, 2018

Summary

This PR adds note to globals setting that its contents need to be json serializable, and thus its not supporting functions for its values. This is something that originally has bitten me once I've moved to parallelized tests execution and it feels to me that this should be documented somewhere.

Test plan

This is documentation's change.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #5287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5287   +/-   ##
=======================================
  Coverage   60.98%   60.98%           
=======================================
  Files         203      203           
  Lines        6816     6816           
  Branches        4        3    -1     
=======================================
  Hits         4157     4157           
  Misses       2658     2658           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d07714...126de21. Read the comment docs.

@cpojer cpojer merged commit 19376c1 into jestjs:master Jan 12, 2018
@cpojer
Copy link
Member

cpojer commented Jan 12, 2018

Thank you!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants