Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocking for boolean values. #713

Closed
wants to merge 1 commit into from
Closed

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Feb 17, 2016

I cannot believe this was never an issue before? wtf.?

@cpojer
Copy link
Member Author

cpojer commented Feb 17, 2016

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/680807545393429/int_phab to review.

@denvned
Copy link

denvned commented Feb 17, 2016

I cannot believe this was never an issue before? wtf.?

At least indirectly it was: #634

@cpojer
Copy link
Member Author

cpojer commented Feb 17, 2016

Yep, fixing that one is next on my list :)

@denvned
Copy link

denvned commented Feb 17, 2016

Cool, looking forward to it! (Probably that is the only issue that block us from upgrading to Babel 6).

@cpojer
Copy link
Member Author

cpojer commented Feb 17, 2016

Now that #599 is landed I can finally get to some of those silly bugs we have in open source Jest :)

@ghost ghost closed this in 68c2162 Feb 18, 2016
@mgenev
Copy link

mgenev commented May 26, 2016

mocking arrays is also broken, they come out empty with jest

@cpojer
Copy link
Member Author

cpojer commented May 31, 2016

@mgenev that is what automocking does. A mock of an array is an empty array. You can fill it out with a manual mock or explicit mock. This is expected. If this is not what you want, I recommend disabling automocking.

@cpojer cpojer deleted the mocker-fix branch June 15, 2016 20:15
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants