Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect: Improve report when assertion fails, part 4 #7241

Merged
merged 15 commits into from
Dec 18, 2018
Merged

expect: Improve report when assertion fails, part 4 #7241

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
71eb406
expect: Improve report when assertion fails, part 4
pedrottimark Oct 22, 2018
975ef50
Added snapshot test for toHaveLength expected length
pedrottimark Oct 22, 2018
d4ff133
Fix prettier lint error
pedrottimark Oct 23, 2018
0e63ecf
Made improvements requested by thymikee
pedrottimark Oct 24, 2018
62125b9
Make improvements suggested by SimenB
pedrottimark Oct 24, 2018
4b3bfc1
Update CHANGELOG.md
pedrottimark Oct 25, 2018
67ecbd1
Merge branch 'master' into improve-report-4
pedrottimark Oct 25, 2018
bbcd2eb
Merge branch 'master' into improve-report-4
thymikee Oct 26, 2018
d4cfa27
Resolve merge conflict in CHANGELOG.md
pedrottimark Nov 18, 2018
04d8cdc
Resolve another merge conflict in CHANGELOG.md
pedrottimark Nov 18, 2018
20ca1aa
Save the change to resolve the other merge conflict
pedrottimark Nov 18, 2018
42e0c42
Deleted assertion_counts.test.js.snap
pedrottimark Nov 18, 2018
a6e3523
Resolve merge conflict with CHANGELOG.md
pedrottimark Dec 12, 2018
8779d94
Replace cannot with must not
pedrottimark Dec 12, 2018
09e5bc9
Fix prettier lint error
pedrottimark Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
- `[jest-config]` Accept an array as as well as a string for `testRegex`([#7209]https://github.com/facebook/jest/pull/7209))
- `[babel-preset-jest]` [**BREAKING**] Export a function instead of an object for Babel 7 compatibility ([#7203](https://github.com/facebook/jest/pull/7203))
- `[expect]` Check constructor equality in .toStrictEqual() ([#7005](https://github.com/facebook/jest/pull/7005))
- `[expect/jest-matcher-utils]` Improve report when assertion fails, part 4 ([#7241](https://github.com/facebook/jest/pull/7241))

### Fixes

Expand Down
10 changes: 10 additions & 0 deletions packages/expect/src/__tests__/__snapshots__/assertion_counts.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`.hasAssertions() throws if expected is not undefined 1`] = `
"<dim>expect(</><red>received</><dim>)[.not].hasAssertions(</><dim>)</>

<bold>Matcher error</>: <green>expected</> value must be omitted or undefined

Expected has type: number
Expected has value: <green>2</>"
`;
Loading