Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example usage of expect().rejects #7431

Closed
wants to merge 1 commit into from

Conversation

jkjustjoshing
Copy link

I tried following the docs to learn how expect().rejects works, but I couldn't get my tests to pass. I then found https://jestjs.io/docs/en/tutorial-async#rejects and that got my tests to pass. This PR updates the docs to match.

Summary

Test plan

I tried following the docs to learn how `expect().rejects` works, but I couldn't get my tests to pass. I then found https://jestjs.io/docs/en/tutorial-async#rejects and that got my tests to pass. This commit updates the docs to match.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would be good for @SimenB to take a look

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought toThrow worked...

@jkjustjoshing
Copy link
Author

Someone should definitely confirm - I've been using Jest all of 2 days! But the inconsistency caught my eye.

@SimenB
Copy link
Member

SimenB commented Nov 29, 2018

Related: #4884

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, the .toThrow version works for me

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jkjustjoshing
Copy link
Author

Weird, I guess I'll have to chalk it up to me being new to Jest! Thanks for taking the time to check.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants