-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enforce LF line endings #8809
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,19 @@ | ||
# EditorConfig helps developers define and maintain consistent | ||
# coding styles between different editors and IDEs | ||
# editorconfig.org | ||
# | ||
# Some of these options are also respected by Prettier | ||
|
||
root = true | ||
|
||
[*] | ||
indent_style = space | ||
indent_size = 2 | ||
|
||
end_of_line = lf | ||
charset = utf-8 | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true | ||
|
||
[{*.md,*.snap}] | ||
[*.{md,snap}] | ||
trim_trailing_whitespace = false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,8 +86,8 @@ | |
"jest-coverage": "yarn jest --coverage", | ||
"lint": "eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md", | ||
"lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5", | ||
"lint:md": "yarn --silent lint:md:ci --fix", | ||
"lint:md:ci": "prettylint '**/*.{md,yml,yaml}' --ignore-path .gitignore", | ||
"lint:prettier": "yarn --silent lint:prettier:ci --fix", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thought I'd also rename the script while on it since it's no longer just |
||
"lint:prettier:ci": "prettylint '**/*.{md,yml,yaml}' --ignore-path .gitignore", | ||
"postinstall": "opencollective postinstall && yarn build", | ||
"publish": "yarn build-clean && yarn build && lerna publish --silent", | ||
"test-ci-es5-build-in-browser": "karma start --single-run", | ||
|
48 changes: 24 additions & 24 deletions
48
packages/expect/src/__tests__/__arbitraries__/sharedSettings.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,24 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
import fc from 'fast-check'; | ||
// settings for anything arbitrary | ||
export const anythingSettings = { | ||
key: fc.oneof(fc.string(), fc.constantFrom('k1', 'k2', 'k3')), | ||
maxDepth: 2, // Limit object depth (default: 2) | ||
maxKeys: 5, // Limit number of keys per object (default: 5) | ||
withBoxedValues: true, | ||
// Issue #7975 have to be fixed before enabling the generation of Map | ||
withMap: false, | ||
// Issue #7975 have to be fixed before enabling the generation of Set | ||
withSet: false, | ||
}; | ||
// assertion settings | ||
export const assertSettings = {}; // eg.: {numRuns: 10000} | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
import fc from 'fast-check'; | ||
|
||
// settings for anything arbitrary | ||
export const anythingSettings = { | ||
key: fc.oneof(fc.string(), fc.constantFrom('k1', 'k2', 'k3')), | ||
maxDepth: 2, // Limit object depth (default: 2) | ||
maxKeys: 5, // Limit number of keys per object (default: 5) | ||
withBoxedValues: true, | ||
// Issue #7975 have to be fixed before enabling the generation of Map | ||
withMap: false, | ||
// Issue #7975 have to be fixed before enabling the generation of Set | ||
withSet: false, | ||
}; | ||
|
||
// assertion settings | ||
export const assertSettings = {}; // eg.: {numRuns: 10000} |
96 changes: 48 additions & 48 deletions
96
packages/expect/src/__tests__/matchers-toContain.property.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,48 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
import fc from 'fast-check'; | ||
import { | ||
anythingSettings, | ||
assertSettings, | ||
} from './__arbitraries__/sharedSettings'; | ||
describe('toContain', () => { | ||
it('should always find the value when inside the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.anything(anythingSettings).filter(v => !Number.isNaN(v)), | ||
(startValues, endValues, v) => { | ||
// Given: startValues, endValues arrays and v value (not NaN) | ||
expect([...startValues, v, ...endValues]).toContain(v); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
it('should not find the value if it has been cloned into the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.dedup(fc.anything(anythingSettings), 2), | ||
(startValues, endValues, [a, b]) => { | ||
// Given: startValues, endValues arrays | ||
// and [a, b] equal, but not the same values | ||
// with `typeof a === 'object && a !== null` | ||
fc.pre(typeof a === 'object' && a !== null); | ||
expect([...startValues, a, ...endValues]).not.toContain(b); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
}); | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
import fc from 'fast-check'; | ||
import { | ||
anythingSettings, | ||
assertSettings, | ||
} from './__arbitraries__/sharedSettings'; | ||
|
||
describe('toContain', () => { | ||
it('should always find the value when inside the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.anything(anythingSettings).filter(v => !Number.isNaN(v)), | ||
(startValues, endValues, v) => { | ||
// Given: startValues, endValues arrays and v value (not NaN) | ||
expect([...startValues, v, ...endValues]).toContain(v); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
|
||
it('should not find the value if it has been cloned into the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.dedup(fc.anything(anythingSettings), 2), | ||
(startValues, endValues, [a, b]) => { | ||
// Given: startValues, endValues arrays | ||
// and [a, b] equal, but not the same values | ||
// with `typeof a === 'object && a !== null` | ||
fc.pre(typeof a === 'object' && a !== null); | ||
expect([...startValues, a, ...endValues]).not.toContain(b); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
}); |
92 changes: 46 additions & 46 deletions
92
packages/expect/src/__tests__/matchers-toContainEqual.property.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,46 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
import fc from 'fast-check'; | ||
import { | ||
anythingSettings, | ||
assertSettings, | ||
} from './__arbitraries__/sharedSettings'; | ||
describe('toContainEqual', () => { | ||
it('should always find the value when inside the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.anything(anythingSettings), | ||
(startValues, endValues, v) => { | ||
// Given: startValues, endValues arrays and v any value | ||
expect([...startValues, v, ...endValues]).toContainEqual(v); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
it('should always find the value when cloned inside the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.dedup(fc.anything(anythingSettings), 2), | ||
(startValues, endValues, [a, b]) => { | ||
// Given: startValues, endValues arrays | ||
// and [a, b] identical values | ||
expect([...startValues, a, ...endValues]).toContainEqual(b); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
}); | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
*/ | ||
|
||
import fc from 'fast-check'; | ||
import { | ||
anythingSettings, | ||
assertSettings, | ||
} from './__arbitraries__/sharedSettings'; | ||
|
||
describe('toContainEqual', () => { | ||
it('should always find the value when inside the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.anything(anythingSettings), | ||
(startValues, endValues, v) => { | ||
// Given: startValues, endValues arrays and v any value | ||
expect([...startValues, v, ...endValues]).toContainEqual(v); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
|
||
it('should always find the value when cloned inside the array', () => { | ||
fc.assert( | ||
fc.property( | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.array(fc.anything(anythingSettings)), | ||
fc.dedup(fc.anything(anythingSettings), 2), | ||
(startValues, endValues, [a, b]) => { | ||
// Given: startValues, endValues arrays | ||
// and [a, b] identical values | ||
expect([...startValues, a, ...endValues]).toContainEqual(b); | ||
}, | ||
), | ||
assertSettings, | ||
); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this pretty much looks like the typical editorconfig examples, except for the
md
/snap
override