Refractor requireAndTranspileModule to use exts from moduleFileExtenstions #8895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the current implementation of
requireAndTranspileModule
theextensions
used for pirates is determined bypath.extname
.path.extname
returns empty string for directories, which resulted inPnP
test failing in #8854. Restricting the extensions to the ones specified inmoduleFileExtensions
/cc @SimenB @jeysal
Test plan
Existing tests should not break
All PRs related to #8810 should not be affected