Support different coverage options in projects #9633

royra · 2020-03-04T09:50:21Z

Summary

Having the coverage configuration at the global config is not consistent with the way it runs. The globs and paths specified at collectCoverageFrom, collectCoverageOnlyFrom, coverageThreshold are relative to the projects' <rootDir> (i.e, do not include the project path), but there is no way to specify options for a specific project.

You can create a union of the configuration for all projects and put it in the global config, but this has the side effect of creating ambiguities. For example, consider the following configuration:

{
  collectCoverageFrom: [
    "index.js",  // package1 wants index.js covered
    "!index.js",  // package2 wants it excluded
  ]
}

This PR moves the following config props from globalConfig to projectConfig:
collectCoverageFrom, collectCoverageOnlyFrom, coverageThreshold

Those properties can now be specified per project.
(Of course, you can still specify them at the global config if projects are not used)

As a side effect, they were removed from the whitelist of watch-able properties.

Fixes the following issues:
#9628 (opened by me)
#6998
#7733 (partial solution)
#8722
#8793
#6483
#6143
#5457
#4255

Test plan

Added an e2e test from the case described at #9628.

facebook-github-bot · 2020-03-04T09:50:30Z

Hi @royra!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2020-03-04T10:00:54Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

drew-gross · 2020-03-04T10:47:33Z

Codecov Report

Merging #9633 into master will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9633      +/-   ##
==========================================
+ Coverage   65.09%   65.29%   +0.20%     
==========================================
  Files         287      312      +25     
  Lines       12144    12226      +82     
  Branches     3009     3008       -1     
==========================================
+ Hits         7905     7983      +78     
- Misses       3604     3606       +2     
- Partials      635      637       +2

Impacted Files	Coverage Δ
examples/manual-mocks/models/user.js	`100.00% <0.00%> (ø)`
examples/react/CheckboxWithLabel.js	`100.00% <0.00%> (ø)`
examples/angular/shared/sub.service.ts	`0.00% <0.00%> (ø)`
examples/jquery/displayUser.js	`100.00% <0.00%> (ø)`
examples/typescript/sum.js	`100.00% <0.00%> (ø)`
examples/angular/shared/data.service.ts	`100.00% <0.00%> (ø)`
examples/timer/timerGame.js	`100.00% <0.00%> (ø)`
e2e/coverage-projects/packages/mul/other_file.js	`100.00% <0.00%> (ø)`
examples/automatic-mocks/utils.js	`50.00% <0.00%> (ø)`
examples/timer/infiniteTimerGame.js	`85.71% <0.00%> (ø)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3aa106...e5b4db1. Read the comment docs.

codecov-io · 2020-03-04T12:49:17Z

Codecov Report

Merging #9633 into master will increase coverage by 0.20%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #9633      +/-   ##
==========================================
+ Coverage   64.92%   65.13%   +0.20%     
==========================================
  Files         288      313      +25     
  Lines       12184    12266      +82     
  Branches     3022     3019       -3     
==========================================
+ Hits         7911     7989      +78     
- Misses       3635     3637       +2     
- Partials      638      640       +2

Impacted Files	Coverage Δ
packages/jest-config/src/index.ts	`11.59% <ø> (ø)`
packages/jest-core/src/lib/update_global_config.ts	`80.00% <ø> (-1.64%)`	⬇️
packages/jest-core/src/watch.ts	`78.53% <ø> (ø)`
...ckages/jest-reporters/src/generateEmptyCoverage.ts	`66.66% <ø> (ø)`
packages/jest-runner/src/runTest.ts	`2.17% <ø> (ø)`
packages/jest-runtime/src/index.ts	`64.75% <ø> (ø)`
packages/jest-reporters/src/coverage_reporter.ts	`54.49% <83.33%> (+0.59%)`	⬆️
e2e/coverage-projects/packages/add/index.js	`100.00% <100.00%> (ø)`
e2e/coverage-projects/packages/mul/other_file.js	`100.00% <100.00%> (ø)`
packages/jest-reporters/src/get_watermarks.ts	`100.00% <100.00%> (ø)`
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd98198...e30321d. Read the comment docs.

royra · 2020-03-24T13:48:22Z

@SimenB @thymikee @jeysal any chance to get this reviewed?

jeysal · 2020-03-24T19:28:06Z

Hi, at some point it surely will be, it's just that all maintainers currently have very little time, sorry about that 😐

Moved the following config props from globalConfig to projectConfig: collectCoverageFrom, collectCoverageOnlyFrom, coverageThreshold You can now specify those properties per project. As a side effect, they were removed from the whitelist of watch-able properties.

SimenB

Sorry about the slow review 😬 The code itself looks solid, but I think we might need to support changing these in watch plugins. Not 100% though. @rogeliog @thymikee @jeysal thoughts?

SimenB · 2020-04-22T08:31:00Z

TestUtils.ts

@@ -12,12 +12,9 @@ const DEFAULT_GLOBAL_CONFIG: Config.GlobalConfig = {
  changedFilesWithAncestor: false,
  changedSince: '',
  collectCoverage: false,


why not all the coverage* options?

SimenB · 2020-04-22T08:32:07Z

docs/WatchPlugins.md

@@ -157,8 +157,6 @@ For stability and safety reasons, only part of the global configuration keys can
 - [`bail`](configuration.html#bail-number--boolean)
 - [`changedSince`](cli.html#--changedsince)
 - [`collectCoverage`](configuration.html#collectcoverage-boolean)
- [`collectCoverageFrom`](configuration.html#collectcoveragefrom-array)


I think watch plugins should still be able to set these, somehow... Might have to solve watchplugins setting project options before we can land this

SimenB · 2020-04-22T08:32:33Z

jest.config.js

@@ -61,6 +61,7 @@ module.exports = {
    '/packages/jest-worker/src/__performance_tests__',
    '/packages/pretty-format/perf/test.js',
    '/e2e/__tests__/iterator-to-null-test.ts',
+    '/.history',


what's this directory?

codecov-commenter · 2020-05-25T04:32:03Z

Codecov Report

Merging #9633 into master will increase coverage by 0.20%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #9633      +/-   ##
==========================================
+ Coverage   64.88%   65.08%   +0.20%     
==========================================
  Files         289      314      +25     
  Lines       12229    12311      +82     
  Branches     3030     3027       -3     
==========================================
+ Hits         7935     8013      +78     
- Misses       3654     3656       +2     
- Partials      640      642       +2

Impacted Files	Coverage Δ
packages/jest-config/src/index.ts	`11.59% <ø> (ø)`
packages/jest-core/src/lib/update_global_config.ts	`80.00% <ø> (-1.64%)`	⬇️
packages/jest-core/src/watch.ts	`78.53% <ø> (ø)`
...ckages/jest-reporters/src/generateEmptyCoverage.ts	`66.66% <ø> (ø)`
packages/jest-runner/src/runTest.ts	`2.22% <ø> (ø)`
packages/jest-runtime/src/index.ts	`64.68% <ø> (ø)`
packages/jest-reporters/src/coverage_reporter.ts	`54.49% <83.33%> (+0.59%)`	⬆️
e2e/coverage-projects/packages/add/index.js	`100.00% <100.00%> (ø)`
e2e/coverage-projects/packages/mul/other_file.js	`100.00% <100.00%> (ø)`
packages/jest-reporters/src/get_watermarks.ts	`100.00% <100.00%> (ø)`
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c830517...e44574f. Read the comment docs.

justinbayctxs · 2020-07-13T20:10:09Z

Got pretty far in switching a monorepo to use Jest's multi-project feature and had to stop when I hit these coverage issues. Would love to see this landed 💯

ziofat · 2020-11-18T08:40:34Z

Well, any updates on this? We are facing the same issue and will be glad to have this feature.

starikcetin · 2021-02-28T11:07:38Z

This PR needs some love, my coverage report only shows the covered files and nothing about the uncovered files.

this is a workaround until this PR gets merged: jestjs/jest#9633

piranna · 2021-12-22T22:39:54Z

This PR needs some love, my coverage report only shows the covered files and nothing about the uncovered files.

Can this PR get merged? I'm getting the same issues than @starikcetin.

piranna · 2021-12-23T22:20:24Z

How can we get this to move forward and get it merged?

SimenB · 2022-01-05T21:30:47Z

How can we get this to move forward and get it merged?

Nothing has changed since my review in 2020 (and I've honestly lost all context here, so once those comments are resolved (mainly we need to figure out how this interacts with watch plugins)) I'll need to take a new look at this

github-actions · 2023-01-05T21:31:53Z

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions · 2023-02-04T21:41:29Z

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.

github-actions · 2023-03-07T00:09:35Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label Mar 4, 2020

royra force-pushed the master branch from ec55cb7 to d956621 Compare March 4, 2020 10:28

royra force-pushed the master branch 2 times, most recently from 765ba3c to e5b4db1 Compare March 4, 2020 11:11

royra mentioned this pull request Mar 4, 2020

projects and collectCoverageFrom do not work together #9628

Closed

royra mentioned this pull request Mar 5, 2020

fix coverage script salto-io/salto#755

Closed

royra force-pushed the master branch 2 times, most recently from 36c1817 to e30321d Compare March 25, 2020 11:14

denisx mentioned this pull request Apr 10, 2020

How to disable empty paths at coverageThreshold when --onlyChanged #9787

Closed

Roy Razon added 3 commits April 12, 2020 20:52

added e2e test

0e60dee

added .history to ignored files

e44574f

royra force-pushed the master branch from e30321d to e44574f Compare April 12, 2020 18:04

SimenB requested changes Apr 22, 2020

View reviewed changes

starikcetin added a commit to ctisbtes/btes that referenced this pull request Feb 28, 2021

fixed root jest coverage report

58736c1

this is a workaround until this PR gets merged: jestjs/jest#9633

starikcetin added a commit to ctisbtes/btes that referenced this pull request Feb 28, 2021

fixed root jest coverage report

eeeb06d

this is a workaround until this PR gets merged: jestjs/jest#9633

github-actions bot added the Stale label Jan 5, 2023

github-actions bot closed this Feb 4, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support different coverage options in projects #9633

Support different coverage options in projects #9633

royra commented Mar 4, 2020 •

edited

Loading

facebook-github-bot commented Mar 4, 2020

facebook-github-bot commented Mar 4, 2020

drew-gross commented Mar 4, 2020 •

edited

Loading

codecov-io commented Mar 4, 2020 •

edited

Loading

royra commented Mar 24, 2020

jeysal commented Mar 24, 2020

SimenB left a comment

SimenB Apr 22, 2020

SimenB Apr 22, 2020

SimenB Apr 22, 2020

codecov-commenter commented May 25, 2020

justinbayctxs commented Jul 13, 2020

ziofat commented Nov 18, 2020

starikcetin commented Feb 28, 2021

piranna commented Dec 22, 2021

piranna commented Dec 23, 2021

SimenB commented Jan 5, 2022

github-actions bot commented Jan 5, 2023

github-actions bot commented Feb 4, 2023

github-actions bot commented Mar 7, 2023

Support different coverage options in projects #9633

Support different coverage options in projects #9633

Conversation

royra commented Mar 4, 2020 • edited Loading

Summary

Test plan

facebook-github-bot commented Mar 4, 2020

facebook-github-bot commented Mar 4, 2020

drew-gross commented Mar 4, 2020 • edited Loading

Codecov Report

codecov-io commented Mar 4, 2020 • edited Loading

Codecov Report

royra commented Mar 24, 2020

jeysal commented Mar 24, 2020

SimenB left a comment

Choose a reason for hiding this comment

SimenB Apr 22, 2020

Choose a reason for hiding this comment

SimenB Apr 22, 2020

Choose a reason for hiding this comment

SimenB Apr 22, 2020

Choose a reason for hiding this comment

codecov-commenter commented May 25, 2020

Codecov Report

justinbayctxs commented Jul 13, 2020

ziofat commented Nov 18, 2020

starikcetin commented Feb 28, 2021

piranna commented Dec 22, 2021

piranna commented Dec 23, 2021

SimenB commented Jan 5, 2022

github-actions bot commented Jan 5, 2023

github-actions bot commented Feb 4, 2023

github-actions bot commented Mar 7, 2023

royra commented Mar 4, 2020 •

edited

Loading

drew-gross commented Mar 4, 2020 •

edited

Loading

codecov-io commented Mar 4, 2020 •

edited

Loading