Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #12313 - Jetty 12 ee9/ee10 doesn't invoke callbacks when h2 client sends RST_STREAM. #12370

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fixes #12313 - Jetty 12 ee9/ee10 doesn't invoke callbacks when h2 client sends RST_STREAM. #12370

merged 3 commits into from
Oct 24, 2024

Commits on Oct 10, 2024

  1. Fixes #12313 - Jetty 12 ee9/ee10 doesn't invoke callbacks when h2 cli… 

    …ent sends RST_STREAM.

* Fixed invocation of AsyncListener.onError(), now called even if the response is already committed, in both EE9 and EE10.
* Reworked EE9 HttpChannel state machine in case of failures to be like EE10's.
  In particular, calling abort now is a state change, rather than a failure of the Handler callback.
  In this way, the handle() loop continues, enters case TERMINATED, and the callback is completed in onCompleted().
* Fixed EE9 handling of idle timeout in HttpChannel.onRequest(), that was missing.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e75b294 View commit details
    Browse the repository at this point in the history

  2. Fixes #12313 - Jetty 12 ee9/ee10 doesn't invoke callbacks when h2 cli… 

    …ent sends RST_STREAM.

* Removed unnecessary calls to EE9's `HttpChannel.abort()`.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b9a6911 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Fixes #12313 - Jetty 12 ee9/ee10 doesn't invoke callbacks when h2 cli… 

    …ent sends RST_STREAM.

* Do not recycle EE9 HttpChannel for WebSocket requests.
* Simplified sendError() error handling.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    @sbordet
    sbordet committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    672d2b3 View commit details
    Browse the repository at this point in the history