Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support vcpkg #1112

Closed
kreuzerkrieg opened this issue Dec 23, 2021 · 9 comments
Closed

[FEATURE] Support vcpkg #1112

kreuzerkrieg opened this issue Dec 23, 2021 · 9 comments
Labels
feature New feature or request

Comments

@kreuzerkrieg
Copy link

Any chance to get eve added to the vcpkg repo?

@kreuzerkrieg kreuzerkrieg added the feature New feature or request label Dec 23, 2021
@jfalcou jfalcou changed the title [FEATURE] [FEATURE] Support vcpkg Dec 23, 2021
@jfalcou
Copy link
Owner

jfalcou commented Dec 23, 2021

This is something we can look into. Now, the MSVC support of EVE is still in the work.

@kreuzerkrieg
Copy link
Author

Not related to MSVC, vcpkg is cross platform, I'm using it on ubuntu with clang. When declaring in the package supported platforms and compilers just skip MSVC.

@jfalcou
Copy link
Owner

jfalcou commented Dec 23, 2021

Sounds fair, we'll give it a try then.

@kreuzerkrieg
Copy link
Author

If you think it will take you too much time to get to this task I can take it. It's been a while since I touched the vcpkg but I guess I can do it in a couple of hours

@jfalcou
Copy link
Owner

jfalcou commented Dec 23, 2021

If you have some experience, patches are welcomed! We'll help you if some idiosyncrasies are required.

@kreuzerkrieg
Copy link
Author

I will submit it directly to vcpkg, then you can grab it and take it from here on

@jfalcou
Copy link
Owner

jfalcou commented Dec 23, 2021

Great

@kreuzerkrieg
Copy link
Author

Done
microsoft/vcpkg#22179

@jfalcou
Copy link
Owner

jfalcou commented Dec 29, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants