Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] java compliant line and column counting [sf#28] #163

Open
lsf37 opened this issue Feb 15, 2015 · 5 comments
Open

[Feature] java compliant line and column counting [sf#28] #163

lsf37 opened this issue Feb 15, 2015 · 5 comments
Labels
enhancement Feature requests help wanted Good first issues

Comments

@lsf37
Copy link
Member

lsf37 commented Feb 15, 2015

Reported by vbstudio on 2013-03-11 15:05 UTC
It would be nice to have an option to switch line and column counting into a mode that will only count \n and \r\n as new lines. I didnt't find an editor that handles the unicode line breaks correctly anyway and i am trying to write a java compliant lexer.

mfG Michael
https://sourceforge.net/p/jflex/feature-requests/28/

@lsf37 lsf37 changed the title java compliant line and column counting [Feature] java compliant line and column counting [sf#28] Feb 15, 2015
@lsf37 lsf37 added this to the jflex milestone Feb 15, 2015
@lsf37
Copy link
Member Author

lsf37 commented Feb 15, 2015

Commented by vbstudio on 2013-03-13 22:51 UTC
actually java regards a sole \r as new line aswell

@lsf37
Copy link
Member Author

lsf37 commented Feb 15, 2015

Commented by vbstudio on 2013-03-14 18:39 UTC
patch against the latest svn revision (623)

@lsf37
Copy link
Member Author

lsf37 commented Feb 15, 2015

Commented by vbstudio on 2013-03-14 18:40 UTC
patch against the current release 1.4.3 to add a switch %javanl that switches to java compliant new line mode

@lsf37 lsf37 added the enhancement Feature requests label Feb 15, 2015
@lsf37 lsf37 removed this from the jflex milestone Feb 15, 2015
@regisd
Copy link
Member

regisd commented Sep 16, 2018

@lsf37 Should we update the patch, or is this obsolete by the full unicode support?

@lsf37
Copy link
Member Author

lsf37 commented Sep 16, 2018

I don't think it's really obsolete, so we should probably update and/or incorporate it. We seem to have forgotten about this one since 1.4.3, so I'll assign this to milestone 1.7.1 to have a more thorough look.

@lsf37 lsf37 added this to the 1.7.1 milestone Sep 16, 2018
@regisd regisd added the help wanted Good first issues label Oct 5, 2018
@regisd regisd modified the milestones: 1.7.1, 1.8.0 Nov 5, 2019
@regisd regisd removed this from the 1.8.0 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests help wanted Good first issues
Projects
None yet
Development

No branches or pull requests

2 participants