Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed conflicting dependency #69

Merged
merged 1 commit into from
Dec 14, 2015
Merged

Conversation

muellerfabian
Copy link
Contributor

  • Removed conflicting dependency of
    'org.apache.httpcomponents:httpclient'.
  • Downstream projects which enforce dependency convergence fail on
    this.

 - Removed conflicting dependency of
   'org.apache.httpcomponents:httpclient'.
 - Downstream projects which enforce dependency convergence fail on
   this.
eyalbe4 added a commit that referenced this pull request Dec 14, 2015
Removed conflicting dependency
@eyalbe4 eyalbe4 merged commit cd8956f into jfrog:master Dec 14, 2015
@muellerfabian
Copy link
Contributor Author

Hey @eyalbe4 ,
Thanks for merging. Could you give me an estimate when this will be released?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Dec 16, 2015

Sure @muellerfabian. The next release will be out in next few days.

@muellerfabian
Copy link
Contributor Author

Hey @eyalbe4,
Could you check if these changes went into version 1.2.0? It seems like this dependency exclusion is not reflected in the generated pom file. Building manually works.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 5, 2016

Hi @muellerfabian ,
I've just double checked this. 1.2.0 was built from the master branch after your commit.
Are you saying that you get a different pom file than 1.2.0's pom when building manually? Are you building from the master branch?

@muellerfabian
Copy link
Contributor Author

Thanks for checking @eyalbe4 ,
yes, I'm building from the master branch. This is the pom file that I get when I run publishToMavenLocal, which includes the dependency exclusion:
https://gist.github.com/muellerfabian/abec1672c4fbd8864c79#file-artifactory-java-client-services-1-2-0-pom-L38-L41
The one on bintray however doesn't have this exclusion:
https://bintray.com/jfrog/artifactory-tools/artifactory-client-java/1.2.0/view#files/org/jfrog/artifactory/client/artifactory-java-client-services/1.2.0

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 6, 2016

Thanks @muellerfabian.
We'll investigate this and update once we find the cause of this exclusion removal.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 12, 2016

@muellerfabian , this issue is probably caused by GRADLE-2945 which seems to have been fixed. We will release client again with a Gradle version that includes the fix.

@muellerfabian
Copy link
Contributor Author

Thanks for the update @eyalbe4. When do you plan to release this?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 22, 2016

Hi @muellerfabian,
We will have a new release in the next few days.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Jan 28, 2016

@muellerfabian,
Version 1.2.2 with this fix has been released to Bintray.

@muellerfabian
Copy link
Contributor Author

Thanks very much @eyalbe4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants