Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle Proxy Enablement ignores no_proxy rules #728

Closed
Enquier opened this issue Jun 6, 2020 · 6 comments · Fixed by jfrog/artifactory-gradle-plugin#120
Closed

Gradle Proxy Enablement ignores no_proxy rules #728

Enquier opened this issue Jun 6, 2020 · 6 comments · Fixed by jfrog/artifactory-gradle-plugin#120
Labels
bug Something isn't working

Comments

@Enquier
Copy link

Enquier commented Jun 6, 2020

Describe the bug
The changes introduced in #359 while important disable the ability to specify a proxy for resolving external dependencies while publishing to an internal repository. For example you might be pulling from an external repository such as external jcenter() or in my case a non-ivy non-maven source that needs manipulation before it can be added to artifactory

To Reproduce

  1. Configure jfrog/gradle to use http/https_proxy with no_proxy for internal sites (ive tried both IP's and DNS names)
  2. Configure a dependency resolution repository that requires a proxy to access
  3. Perform gradle tasks including dependency resolution via proxy
  4. Publish Artifacts to internal Artifactory

Expected behavior
Gradle/Artifactory plugin to respect no_proxy rules

Versions

  • JFrog CLI version: Latest
  • JFrog CLI operating system: debian/docker
  • Artifactory Version: 6.17.0

Additional context
Gradle: 4.10.2

@Enquier Enquier added the bug Something isn't working label Jun 6, 2020
@eyalbe4
Copy link
Contributor

eyalbe4 commented Jun 6, 2020

@Enquier,
Thanks for reporting this. We should probability add a "bypass http proxy" option when configuring an Artifactory server through the jfrog rt c command. What do you think?

@Enquier
Copy link
Author

Enquier commented Jun 6, 2020

That would be a great/more general way to manage internal vs external rt servers/other repositories. My use case is rather complex in that I am downloading from an external non-artifactory system manipulating (mostly formatting for maven) that artifact slightly and posting it to our internal artifactory. Either way your proposal sounds like it would work for my use-case

@Enquier
Copy link
Author

Enquier commented Jun 7, 2020

I have added a PR with a fix for this. CLA is not available via link anymore

@joanna-polec
Copy link

Hi, do you have any update about this issue?
I have similar problem with gradle deployment, it ignores NO_PROXY env (there is no such issue for mvn or npm). Only one workaround which works is to unset HTTP_PROXY env before running jf gradle artifactoryPublish...
jfrog cli version: 2.59.1

@yahavi
Copy link
Member

yahavi commented Aug 30, 2024

@joanna-polec
JFrog CLI version 2.65.0 has been released, and it includes a fix for the no-proxy issue during deployment. Please give it a try and let us know your feedback.

@joanna-polec
Copy link

@yahavi
It works on version 2.65.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants