Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling HDR crashes on launch #10

Closed
senpaaii opened this issue Jun 14, 2024 · 2 comments · Fixed by #11
Closed

Enabling HDR crashes on launch #10

senpaaii opened this issue Jun 14, 2024 · 2 comments · Fixed by #11
Assignees

Comments

@senpaaii
Copy link

Plugin crashes when HDR is enabled on a camera. I wanted to use a combination of HDR and this lighting to do some interesting effects, however seems I can't use HDR at the same time

2024-06-14T02:58:52.023829Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default    
thread '<unnamed>' panicked at /src/index.crates.io-6f17d22bba15001f/wgpu-0.19.4/src/backend/wgpu_core.rs:3006:5:
wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 1, Metal)>`
    In a set_pipeline command
      note: render pipeline = `lighting_pipeline`
    Render pipeline targets are incompatible with render pass
    Incompatible color attachments at indices [0]: the RenderPass uses textures with formats [Some(Rgba16Float)] but the RenderPipeline uses attachments with formats [Some(Rgba8UnormSrgb)]
@jgayfer jgayfer added the bug label Jun 14, 2024
@jgayfer
Copy link
Owner

jgayfer commented Jun 14, 2024

Thanks for the report!

I will take a peek next time I'm able.

@jgayfer
Copy link
Owner

jgayfer commented Jun 14, 2024

Looks like to support HDR we need to have a conditional texture format based on the camera. Should be doable; lots of Bevy's internal pipelines do it. Will have a PR hopefully soon.

@jgayfer jgayfer mentioned this issue Jun 15, 2024
@jgayfer jgayfer self-assigned this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants