Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External plugins stopped working #1352

Closed
2 tasks done
appa1303 opened this issue Jun 20, 2023 · 5 comments
Closed
2 tasks done

External plugins stopped working #1352

appa1303 opened this issue Jun 20, 2023 · 5 comments

Comments

@appa1303
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

Describe the bug
On old versions (e.g. 20.8.16) running DrawIO desktop on windows with the --enable-plugins option, allowed me to load external plugin. In version 21.5.0 this no longer works.
To verify I tried to load the numbers.js plugin from ...\drawio-21.5.0\src\main\webapp\plugins as an external plugin and it will not work, using the internal version of the plugin works fine.

To Reproduce
Steps to reproduce the behavior:

  1. start DrawIO desktop on windows from commandline: C:\Program Files\draw.io>draw.io.exe --enable-plugins
  2. Goto extras => Plugin => Add, and add external plugin
  3. Restart drawIO
  4. The plug in is not working
  5. Download the drawIO source from git, locate the numbers.js plugin and install it as external plugin
  6. The numbers.js plugin is not working

Expected behavior
External plugins should have loaded when running drawio desktop with --enable-plugins

Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 21.5.0

Desktop (please complete the following information):
os: Windows 11

Additional context
The plugin I am trying to use worked at least up to version 20.8.16, Since i can't load Numbers.JS also i think it is a problem in drawio desktop

@davidjgraph
Copy link
Contributor

Unfortunately, this is a side effect of security measures we have added to the app. The measures are very important, so the plugin functionality will have to longer be a part of the desktop app.

@appa1303
Copy link
Author

Thank you for the quick reply,

Since the plugin is a must for us, is it possible for us to rebuild DrawIO desktop without the new security measures ?
Can you please direct us to instruction for the building process ?

@davidjgraph
Copy link
Contributor

You can run it up locally using the instructions in the main README.

@davidjgraph
Copy link
Contributor

We'll have a better review to see if this is possible to restore.

@davidjgraph
Copy link
Contributor

Intended fix in 21.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants