Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height 'auto' on html audio tag breaks height of tag #2060

Assignees
Labels

Comments

@gdebrauwer
Copy link

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version [0.7.1]
My browser is: Chrome, Safari

Description

In the minireset.sass file, the audio tag gets a 'height: auto;'. Because of this, the height of audio tag is set to 0 and the audio tag cannot be properly aligned inside an other element.

This has already mentoined in an older issue (#819), but it's still not fixed.

Steps to Reproduce

  1. Add an audio element inside a bulma content element.

Expected behavior

The audio element should have the height assigned by default (user agent stylesheet).

Actual behavior

The audio element has a height of 0px.

@besnik
Copy link

besnik commented Oct 6, 2018

I confirm this is still problem in v0.7.1 in chrome (btw it works okay in firefox).

Steps to reproduce:
Just place audio control inside sample media component/

@frandiox
Copy link

Same thing happens with iframes from Google Hire. The height: auto in minireset.sass makes it collapse and it's hardly visible.

@thekevshow
Copy link

Is there a solution to this, the iframe issue is really causing me problems. Disabling the auto in chrome developer tools shows that it works perfectly after. Also manually editing the css generated.

@jgthms jgthms added the pinned label Mar 29, 2019
@jgthms jgthms self-assigned this Mar 29, 2019
@nathansmonk
Copy link

I am also experiencing this. I discovered this when creating a WordPress theme and unit testing against instagram embeds.

@jgthms
Copy link
Owner

jgthms commented Apr 28, 2019

Will fix this in the next release. Sorry about that.

@lesharris
Copy link

lesharris commented May 19, 2019

I don't think this made it into 0.7.5. minireset.sass is still setting height: auto; for iframes.

// Media
img,
embed,
iframe,
object,
video
height: auto
max-width: 100%

Any chance for a small point release to address this?

@jgthms jgthms closed this as completed in 412bef4 May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment