bugfix: issues/1902 fix for ie11 #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How was this tested? |
|
I've tested this in the current project I'm working on by simply just adding the CSS rule. I've also made a few vanilla tests (including on the Bulma homepage)
It doesn't really change anything honestly, since this flex container just always contains one relative element according to the Bulma description.
|
|
@jgthms Also verified the fix on a free Windows 7 IE11 VM:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1902
This is a bugfix
Proposed solution
Fixes modal not being centered on IE11
Tradeoffs
Drawbacks: none
Testing Done
Yes. Works in IE11, works in Chrome.